From 92d3403b511c541ead6deeaacce1395bff7cfa2d Mon Sep 17 00:00:00 2001 From: Gatt Date: Thu, 16 Jul 2020 22:28:37 +1000 Subject: [PATCH] add inShown check to new holograms stops holograms stacking --- .../main/java/net/jitse/npclib/internal/NPCBase.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/api/src/main/java/net/jitse/npclib/internal/NPCBase.java b/api/src/main/java/net/jitse/npclib/internal/NPCBase.java index 2e056c8..ae7563c 100644 --- a/api/src/main/java/net/jitse/npclib/internal/NPCBase.java +++ b/api/src/main/java/net/jitse/npclib/internal/NPCBase.java @@ -87,10 +87,12 @@ public abstract class NPCBase implements NPC, NPCPacketHandler { originalhologram.hide(targetPlayer); // essentially destroy the hologram textDisplayHolograms.remove(targetPlayer.getUniqueId()); // remove the old obj } - - Hologram hologram = getPlayerHologram(targetPlayer); // - List updatePackets = hologram.getUpdatePackets(getPlayerLines(targetPlayer)); - hologram.update(targetPlayer, updatePackets); + + if (isShown(targetPlayer)) { //only show hologram if the player is in range + Hologram hologram = getPlayerHologram(targetPlayer); + List updatePackets = hologram.getUpdatePackets(getPlayerLines(targetPlayer)); + hologram.update(targetPlayer, updatePackets); + } } return this; }